Fixed "Credit Memo not created when refund issued by merchant" #2729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes, the total of the order and the total of the refund is a little different, +/- 0.001, so when an admin create a refund from PayPal website (or another payment method), we have:
For this example the order total is 61.79:
This PR require php-bcmath. perhaps we can replacebccomp
with another php code to not require onbcmath
.Contribution checklist