Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "Credit Memo not created when refund issued by merchant" #2729

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fixed "Credit Memo not created when refund issued by merchant" #2729

merged 2 commits into from
Oct 4, 2023

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Nov 17, 2022

Description

Sometimes, the total of the order and the total of the refund is a little different, +/- 0.001, so when an admin create a refund from PayPal website (or another payment method), we have:

IPN "Refunded". Refund issued by merchant. Registered notification about refunded amount of -61.79 €. 
Transaction ID: "xxxx". Credit Memo has not been created. Please create offline Credit Memo.

For this example the order total is 61.79:
image

This PR require php-bcmath. perhaps we can replace bccomp with another php code to not require on bcmath.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Nov 17, 2022
@luigifab luigifab marked this pull request as ready for review January 7, 2023 11:14
@luigifab luigifab changed the base branch from 1.9.4.x to main April 9, 2023 08:45
@addison74 addison74 self-assigned this Jul 14, 2023
@fballiano fballiano changed the title Credit Memo not created when refund issued by merchant Fixed "Credit Memo not created when refund issued by merchant" Oct 4, 2023
@fballiano fballiano merged commit bdd0697 into OpenMage:main Oct 4, 2023
17 checks passed
@addison74 addison74 removed their assignment Oct 4, 2023
@luigifab luigifab deleted the bccomp branch October 4, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Relates to Mage_Sales
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants