Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method code in payment method list #2735

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Add method code in payment method list #2735

merged 1 commit into from
Nov 17, 2022

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Nov 17, 2022 •
edited
Loading

Description

In Sales / Transactions, there is a payment method list.
But, sometimes, there are more than one payment method with same name, so I added method code, example:

image

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Payment Relates to Mage_Payment label Nov 17, 2022
fballiano
fballiano approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

genius

@fballiano fballiano merged commit b49720e into OpenMage:1.9.4.x Nov 17, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit b49720e. ± Comparison against base commit 7f75489.

@luigifab luigifab deleted the add-method-code branch November 17, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Payment Relates to Mage_Payment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luigifab @fballiano @addison74