Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect docblock for setLastRealOrderId() and getLastRealOrde… #2752

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Nov 21, 2022

…rId()

Description (*)

real_order_id is order increment_id, which is a string. See

->setLastRealOrderId($order->getIncrementId());

@github-actions github-actions bot added the Component: Checkout Relates to Mage_Checkout label Nov 21, 2022
@kiatng kiatng requested a review from sreichel November 21, 2022 02:38
@fballiano fballiano merged commit d2a08a0 into OpenMage:1.9.4.x Nov 21, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit d2a08a0. ± Comparison against base commit 3453d22.

@kiatng kiatng deleted the docblock_setLastRealOrderId branch February 27, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Relates to Mage_Checkout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants