Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: merge CSS files /w missing file #2754

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Fix: merge CSS files /w missing file #2754

merged 1 commit into from
Nov 22, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 21, 2022 •
edited
Loading

Fixed Issues (if relevant)

  1. Fixes CSS breaks if merging CSS is enabled and there is a missing CSS file (Found on admin but logic should be the same for the frontend) #2753

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Nov 21, 2022
@sreichel sreichel changed the title Log exception Fix: merge CSS files /w missing file Nov 21, 2022
@fballiano fballiano merged commit 861b564 into OpenMage:1.9.4.x Nov 22, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 861b564. ± Comparison against base commit d2a08a0.

@fballiano fballiano mentioned this pull request Nov 22, 2022
Open
@sreichel sreichel deleted the fix-css-merge branch November 22, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@Sdfendor Sdfendor Sdfendor approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core
Projects
None yet
Milestone
No milestone
4 participants
@sreichel @fballiano @Sdfendor @ADDISON74