Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config for admin RSS links, ref #2741 #2760

Closed
wants to merge 10 commits into from
Closed

Use config for admin RSS links, ref #2741 #2760

wants to merge 10 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 25, 2022

Description (*)

@luigifab made a good observation in #2741. RSS links show up on admin grids regardless of RSS is disabled.

I changed it bit different:

Admin Pending Rewies RSS

  • flat tables are disabled here, so we cant filter by products store easly
  • -> made config global

Admin Low Stock RSS

  • whe have only one inventory, only products can be assigned to different websites
  • -> made config global

Admin New Order RSS

  • use config to show/hide links per storeview
  • new; show only orders for filtered store (default/no filter shows all)
  • new; config option for days to mark orders as new

Fixed Issues (if relevant)

  1. Closes Hide and show RSS links #2741

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Rss Relates to Mage_Rss translations Relates to app/locale labels Nov 25, 2022
@sreichel sreichel marked this pull request as draft November 25, 2022 01:10
@sreichel sreichel marked this pull request as ready for review November 25, 2022 01:16
Copy link
Contributor

@luigifab luigifab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested but for me, when I enable RSS link only for one store, the link is never displayed in products/orders/reviews grid.

@sreichel sreichel self-assigned this Jan 1, 2023
@sreichel
Copy link
Contributor Author

sreichel commented Jan 1, 2023

I tested but for me, when I enable RSS link only for one store

With my change you cannot enable/disable "Admin Review Notification" per store. It's changed to global scope for admin grid.

rss

@luigifab luigifab mentioned this pull request Jan 7, 2023
4 tasks
@sreichel sreichel closed this by deleting the head repository Jan 8, 2023
@addison74 addison74 reopened this Jan 9, 2023
@sreichel sreichel closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Rss Relates to Mage_Rss improvement new feature translations Relates to app/locale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants