Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Mage_Backup #2811

Merged
merged 10 commits into from
Jan 3, 2023
Merged

Removed Mage_Backup #2811

merged 10 commits into from
Jan 3, 2023

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 16, 2022 •
edited
Loading

Description (*)

Removed Mage_Backup code.

Can be reinstalled with composer require openmage/module-mage-backup

Related Pull Requests

Questions or comments

Repo should be moved to OM space.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Backup Relates to Mage_Backup Component: Core Relates to Mage_Core Component: lib/Mage Relates to lib/Mage Component: lib/* Relates to lib/* documentation phpstan Template : admin Relates to admin template labels Dec 16, 2022
@fballiano
Copy link
Contributor

but what about my pr? 🥺🥺

@fballiano
Copy link
Contributor

but what about my pr? 🥺🥺

ah right, it was broken.

well, as everybody knows I'm all for this.

fballiano
fballiano previously approved these changes Dec 16, 2022
View reviewed changes
@github-actions github-actions bot added the translations Relates to app/locale label Dec 16, 2022
@addison74
Copy link
Contributor

Here #2024 and here #2259 we discussed this module. @fballiano said that there are big issues in the code of this module that the Magento team no longer wanted to solve, other than the data security ones shown by me.

I personally agree with removing it and installing it from a repository by anyone who is interested. I would go a little further, if we remove the code no one can create PRs from now on. Wouldn't it be better to create a new OpenMage repository here on GitHub so that any contribution can be made and we know about it? Those who are interested can install it either with Composer or put it back by downloading the archive and copying the files in OpenMage installation.

@fballiano
Copy link
Contributor

the repo, at the moment, is https://github.com/sreichel/openmage-module-mage-backup :-)

@addison74
Copy link
Contributor

I know but we should have it as a branch in OpenMage.

@sreichel
Copy link
Contributor Author

@addison74 aggreed, but i cant add repos to OpenMage space.

@sreichel
Merge branch '1.9.4.x' into phpstan/mage-backup
43ea148 
# Conflicts:
#	app/code/core/Mage/Adminhtml/Block/Backup/Grid.php
@fballiano
Copy link
Contributor

I've created https://github.com/OpenMage/module-mage-backup for you

@sreichel
Copy link
Contributor Author

Why i cant do this?

Seems i cannot push.

@fballiano
Copy link
Contributor

I don't know why you can't do that but anyway I've invite you as maintainer for that repo, but it seems the invite was accepted yes

Screenshot 2022-12-18 alle 16 54 45

@sreichel
Copy link
Contributor Author

Thanks. Its there.

@fballiano
Copy link
Contributor

did you change the packagist references too? can you? (I cannot)

@sreichel
Copy link
Contributor Author

yes. moved both

fballiano
fballiano previously approved these changes Dec 18, 2022
View reviewed changes
@fballiano
Copy link
Contributor

Before approving it, I would like to ask you what happens with Tools branch in the Backend > System menu. The "Backups" and "Compilation" links have been grouped here. The latter has been removed from OpenMage for some time, the former via this PR. Under these conditions, System > Tools should no longer exist in OpenMage and it can be removed, I guess through another PR.

I think it would disappear but it wouldn't be a problem because it reappears automatically in case a module (that uses it) gets installed

@sreichel
Copy link
Contributor Author

@addison74 "tools" should not be visible when Mage_Backup is disabled (default). If you enable it "tools" appears.

Flyingmana
Flyingmana previously requested changes Dec 24, 2022
View reviewed changes
Copy link
Contributor

@Flyingmana Flyingmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacement module should have at least one valid Release, just in case we need to do a bugfix or bc breaking release.
Version 1.0.0 would be alright.

PS: I cant do this myself as I did not get permissions assigned for the related repository

README.md Outdated Show resolved Hide resolved
fballiano
fballiano previously approved these changes Dec 25, 2022
View reviewed changes
@addison74
Copy link
Contributor

With the default installation there are 3 modules having the output disabled Mage_Backup, Mage_Poll, Mage_Tag. Sven is right when the Mage_Backup module is disabled from XML configuration or its output in Backend the Tools link doesn't appear in System menu.

If you have made sure that you have identified all the files of this module I don't see what would prevent us from approving it.

@sreichel
Copy link
Contributor Author

With the default installation there are 3 modules having the output disabled Mage_Backup, Mage_Poll, Mage_Tag.

@Flyingmana @fballiano can you please create repos for Mage_Poll and Mage_Tag or give permission? 😎

@fballiano
Copy link
Contributor

I can't give you that permission but I made you admin for https://github.com/OpenMage/module-mage-poll and https://github.com/OpenMage/module-mage-tag

@sreichel
Merge branch '1.9.4.x' into phpstan/mage-backup
667dd5c
@sreichel
Merge branch '1.9.4.x' into phpstan/mage-backup
e672935 
# Conflicts:
#	.gitignore
#	app/code/core/Mage/Backup/Helper/Data.php
#	app/code/core/Mage/Backup/Model/Backup.php
#	app/code/core/Mage/Backup/etc/adminhtml.xml
#	app/code/core/Mage/Backup/etc/config.xml
#	lib/Mage/Backup.php
#	lib/Mage/Backup/Archive/Tar.php
#	lib/Mage/Backup/Db.php
#	lib/Mage/Backup/Exception.php
#	lib/Mage/Backup/Exception/CantLoadSnapshot.php
#	lib/Mage/Backup/Exception/FtpConnectionFailed.php
#	lib/Mage/Backup/Exception/FtpValidationFailed.php
#	lib/Mage/Backup/Exception/NotEnoughFreeSpace.php
#	lib/Mage/Backup/Exception/NotEnoughPermissions.php
#	lib/Mage/Backup/Filesystem.php
#	lib/Mage/Backup/Filesystem/Helper.php
#	lib/Mage/Backup/Filesystem/Rollback/Abstract.php
#	lib/Mage/Backup/Filesystem/Rollback/Fs.php
#	lib/Mage/Backup/Filesystem/Rollback/Ftp.php
#	lib/Mage/Backup/Interface.php
#	lib/Mage/Backup/Media.php
#	lib/Mage/Backup/Nomedia.php
#	lib/Mage/Backup/Snapshot.php
luigifab
luigifab previously approved these changes Jan 1, 2023
View reviewed changes
fballiano
fballiano previously approved these changes Jan 1, 2023
View reviewed changes
@sreichel
Copy link
Contributor Author

sreichel commented Jan 2, 2023

Yeah ... conflicts on a file to delete ... :/

@sreichel
Merge branch '1.9.4.x' into phpstan/mage-backup
3c278e3 
# Conflicts:
#	app/code/core/Mage/Backup/Model/Config/Backend/Cron.php
@sreichel sreichel dismissed stale reviews from fballiano and luigifab via 3c278e3 January 2, 2023 00:11
@fballiano fballiano mentioned this pull request Jan 3, 2023
Merged
fballiano
fballiano approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this is not considered BC while #2863 is, but they're both ok in my opinion

@fballiano fballiano merged commit 1fd35a1 into OpenMage:1.9.4.x Jan 3, 2023
@sreichel sreichel deleted the phpstan/mage-backup branch January 3, 2023 22:11
@sreichel
Copy link
Contributor Author

sreichel commented Jan 3, 2023

Dont think its a breaking change. It should be included in download and everyone who uses composer can install it when required. Just needs some documentation.

fballiano pushed a commit that referenced this pull request Jan 3, 2023
@sreichel @fballiano
Removed Mage_Backup (#2811)
ba7f510
@fballiano
Copy link
Contributor

you know what I was referring to

@fballiano fballiano mentioned this pull request Jan 3, 2023
Merged
@Flyingmana Flyingmana added the backwards compatibility Might affect backwards compatibility for some users label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flyingmana Flyingmana Flyingmana left review comments

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

@luigifab luigifab luigifab left review comments

Assignees
No one assigned
Labels
backwards compatibility Might affect backwards compatibility for some users Component: Adminhtml Relates to Mage_Adminhtml Component: Backup Relates to Mage_Backup Component: Core Relates to Mage_Core Component: lib/Mage Relates to lib/Mage Component: lib/* Relates to lib/* documentation phpstan PHPStorm Template : admin Relates to admin template translations Relates to app/locale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sreichel @fballiano @addison74 @Flyingmana @luigifab