Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct code for Greece VAT validation #2849

Merged
merged 1 commit into from
Dec 25, 2022

Conversation

elidrissidev
Copy link
Member

@elidrissidev elidrissidev commented Dec 25, 2022

Description (*)

Greece uses a different code for VAT validation number (EL) than its ISO-2 country code (GR). This PR backports the fix in magento2 to allow overriding the country code before performing the VAT validation request.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes VAT validation for greek VAT IDs always fails #2828

Manual testing scenarios (*)

  1. Create a customer with Greece country in its address, then try validating the VAT number either from the frontend or admin.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Customer Relates to Mage_Customer label Dec 25, 2022
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@fballiano fballiano merged commit 66af7ed into OpenMage:1.9.4.x Dec 25, 2022
@elidrissidev elidrissidev deleted the fix/greece-vat-validation branch December 25, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Relates to Mage_Customer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VAT validation for greek VAT IDs always fails
3 participants