Updated copyright blocks

[sreichel]

Description (*)

I took me some hours to go though all files that changes and updated copyright blocks .... not.

Just used #2295 👍

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[fballiano]

love it

[Flyingmana]

just, why?
why do we need to update the year in the copyright headers? what is the benefit for anyone?

[addison74]

If I remember correctly the script created by @justinbeaty makes changes only in the files that have been changed in the meantime. There is a long discussion why we need to change the copyright header in a few places (#2276, #2297) and here for legal aspects (#2295).

[sreichel]

@Flyingmana we started this with #2297. Now we can/could/should keep it up to date? Are there any downsides?

[Flyingmana]

the downsides are documented in a decade of people complaining about Magento doing this, because it makes creating diffs a lot harder.
It is also one of these things, causing potential merge conflicts.

on the other side iam not convinced of any of the Advantages.
Its not needed from legal side, or would already be sufficient with once every 70-90 years.
The PCI argument is questionable, because there is no related requirement for it, and would really anyone let this fail because the header was not updated? The people testing this are more interested in the process, then single files.

[fballiano]

in the old times they were updating every single file at every release. we're just updating the files that were actually modified, which makes 78% more sense ;-)
anyway it was a very long discussion and it was decided to accept that PR.

[sreichel]

which makes 78% more sense

82% ... at least.

[addison74]

Changing the header can also be seen as useful information. For example, a file had its last changes in the year 2022. Not that it would help much, but there are files that we have never touched inherited from Magento.