Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rector: automatic code refactoring (part 1) #2879

Merged
merged 18 commits into from
Jan 2, 2023
Merged

rector: automatic code refactoring (part 1) #2879

merged 18 commits into from
Jan 2, 2023

Commits on Jan 1, 2023

  1. Add "never" return-type for methods that never return anything 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#returnnevertyperector
    @sreichel
    sreichel committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    6567777 View commit details
    Browse the repository at this point in the history

  2. Updated phpstan.dist.baseline.neon

    @sreichel
    sreichel committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    82c94c9 View commit details
    Browse the repository at this point in the history

  3. Added ddev rector command shortcut

    @sreichel
    sreichel committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    7d62ab0 View commit details
    Browse the repository at this point in the history

  4. Change array_push() to direct variable assign 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#changearraypushtoarrayassignrector
    @sreichel
    sreichel committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    d811e44 View commit details
    Browse the repository at this point in the history

  5. Replace array_keys() and in_array() to array_key_exists() 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#arraykeysandinarraytoarraykeyexistsrector
    @sreichel
    sreichel committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    e647860 View commit details
    Browse the repository at this point in the history

  6. Use common != instead of less known <> with same meaning 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#commonnotequalrector
    @sreichel
    sreichel committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    3250911 View commit details
    Browse the repository at this point in the history

  7. Issue in rector found ...reverted 

    - see rectorphp/rector#7699
    @sreichel
    sreichel committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    4c209e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2023

  1. Updated phpstan.dist.baseline.neon

    @sreichel
    sreichel committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    2573ba4 View commit details
    Browse the repository at this point in the history

  2. Change compact() call to own array 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#compacttovariablesrector
    @sreichel
    sreichel committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    7f5c741 View commit details
    Browse the repository at this point in the history

  3. Change OR, AND to ||, && with more common understanding 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#logicaltobooleanrector
    @sreichel
    sreichel committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    d88376b View commit details
    Browse the repository at this point in the history

  4. Replace the Double not operator (!!) by type-casting to boolean 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#replacemultiplebooleannotrector
    @sreichel
    sreichel committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    c453b4d View commit details
    Browse the repository at this point in the history

  5. Simplify array_search to in_array 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#simplifyarraysearchrector
    @sreichel
    sreichel committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    b2dab8a View commit details
    Browse the repository at this point in the history

  6. Changes compared to value and return of expr to direct return 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#simplifyifexactvaluereturnvaluerector
    @sreichel
    sreichel committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    035a2e7 View commit details
    Browse the repository at this point in the history

  7. Updated phpstan.dist.baseline.neon 

    This error goes and comes ...
    @sreichel
    sreichel committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    0e3ea54 View commit details
    Browse the repository at this point in the history

  8. Changes strlen comparison to 0 to direct empty string compare 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#strlenzerotoidenticalemptystringrector
    @sreichel
    sreichel committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    fc48314 View commit details
    Browse the repository at this point in the history

  9. Simplify conditions 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#simplifyconditionsrector
    @sreichel
    sreichel committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    55cfa87 View commit details
    Browse the repository at this point in the history

  10. Simplify tautology ternary to value 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#simplifytautologyternaryrector
    @sreichel
    sreichel committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    5e1ce27 View commit details
    Browse the repository at this point in the history

  11. Splits [$a, $b] = [5, 10] scalar assign to standalone lines 

    - see https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#splitlistassigntoseparatelinerector
    @sreichel
    sreichel committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    02c3a72 View commit details
    Browse the repository at this point in the history