Ensure null values are not passed to trim() #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wrong tag @sreichel, my apologies! I was just looking at another 8.1 issue you were fixing 😛 |
Given that we may have attributes without a backend_table defined (null value), safely pass this value into the trim function.
mattdavenport
force-pushed
the
fix/php8.1/backend-table-null-dep
branch
from
d430ea4
to
e0e9744
Compare
sreichel
approved these changes
Jan 3, 2023
fballiano
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Magento allows eav attributes without a backing table (
backend_tablein the DB), we should ensure that thosenullvalues are passable into the trim function. I noticed @sreichel used a string typecast in the larger #2586 PR , so I'm going with that same convention. Alternatively a null coalesce could be used here if that is preferred. This fixes the deprecation notice in PHP 8.1.