Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unmatched error from phpstan baseline #2929

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Remove unmatched error from phpstan baseline #2929

merged 1 commit into from
Jan 13, 2023

Conversation

elidrissidev
Copy link
Member

Description (*)

Only removed the error manually to stop workflow from failing. Can't regenerate the baseline at this time.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@elidrissidev elidrissidev mentioned this pull request Jan 13, 2023
Merged
@fballiano fballiano merged commit 04da476 into OpenMage:1.9.4.x Jan 13, 2023
fballiano pushed a commit that referenced this pull request Jan 13, 2023
@elidrissidev @fballiano
Remove unmatched error from phpstan baseline (#2929)
7acf971
@fballiano
Copy link
Contributor

merged and cherrypicked to v20

@elidrissidev elidrissidev deleted the fix/phpstan-baseline branch January 13, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elidrissidev @fballiano @ADDISON74