Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for mcrypt_compat 2.0.4 #2968

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix for mcrypt_compat 2.0.4 #2968

merged 1 commit into from
Jan 18, 2023

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Jan 18, 2023

Description

This fix the following notice with PHP 8.0.27 and mcrypt_compat 2.0.4.
I'm not sure if it's good or not.

Notice: Only variables should be passed by reference  in lib/Varien/Crypt/Mcrypt.php on line 129

#0 lib/Varien/Crypt/Mcrypt.php(129): mageCoreErrorHandler()
#1 lib/Varien/Crypt/Mcrypt.php(48): Varien_Crypt_Mcrypt->_reset()
#2 [internal function]: Varien_Crypt_Mcrypt->destruct()
#3 {main}
  thrown in lib/Varien/Crypt/Mcrypt.php on line 129
  catched by Mage::printException() via mageCoreErrorHandler()

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* labels Jan 18, 2023
@fballiano fballiano merged commit 2a8e91d into OpenMage:1.9.4.x Jan 18, 2023
@fballiano
Copy link
Contributor

merge and cherrypicked to v20

@luigifab luigifab deleted the mcrypt branch January 19, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants