Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install composer dependencies in gitpod #2989

Merged
merged 2 commits into from
Jan 21, 2023

Conversation

elidrissidev
Copy link
Member

@elidrissidev elidrissidev commented Jan 21, 2023

Description (*)

This PR adds a new container to the local and gitpod docker-compose files to be able to install composer dependencies in the install.sh script. I also fixed a couple of container names in gitpod script, since gitpod uses different names prefixed with gitpod-.

Local docker installation not tested.

Fixed Issues (if relevant)

  1. Fixes Gitpod deployment fails with class Zend_Cache not found #2961

Manual testing scenarios (*)

  1. Creating a new workspace in gitpod should install composer dependencies before trying to install openmage.
  2. Composer dependencies should also get installed when running with locally with docker using dev/openmage/install.sh.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@elidrissidev
Copy link
Member Author

Also, does anyone know why gitpod link is no longer showing in CI checks?

@Flyingmana
Copy link
Contributor

Also, does anyone know why gitpod link is no longer showing in CI checks?

I dont know about it, but I use the browser extension which adds a button in the top right
image

Copy link
Contributor

@Flyingmana Flyingmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works again after a bit of waiting :)

@fballiano fballiano merged commit b04bacc into OpenMage:1.9.4.x Jan 21, 2023
@fballiano
Copy link
Contributor

merged and cherrypicked to v20

@elidrissidev elidrissidev deleted the fix/gitpod-composer-install branch January 21, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitpod deployment fails with class Zend_Cache not found
3 participants