Making optionalZipCountries JS code conditional #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`js/varien/form.js` checks for existence of the variable, hence it's allowed to be undefined if empty. There is more on this. The block is inserted into every Magento page, which seems excessive. It's probably only used in the Cart but I haven't checked thoroughly so leaving it alone for now. Same for the admin.
github-actions
bot
added
Component: Directory
luigifab
reviewed
Feb 3, 2023
|
I will never understand why templates are written in this horrible coding standard, lol. |
fballiano
reviewed
Feb 7, 2023
app/design/frontend/base/default/template/directory/js/optional_zip_countries.phtml
Outdated
Show resolved
Hide resolved
…l_zip_countries.phtml Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
|
@sreichel installed phpmd and phpcs: One of the rules is camelCase. Not against snake_case, but it is better to standardize on camelCase |
fballiano
reviewed
Feb 8, 2023
app/design/frontend/base/default/template/directory/js/optional_zip_countries.phtml
Outdated
Show resolved
Hide resolved
…l_zip_countries.phtml Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
|
good to go |
fballiano
approved these changes
Feb 20, 2023
ADDISON74
approved these changes
Mar 9, 2023
fballiano
added a commit
that referenced
this pull request
Mar 9, 2023
--------- Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
|
merged and 20ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js/varien/form.jschecks for existence of the variable, hence it's allowed to be undefined if empty.There is more on this. The block is inserted into every Magento page, which seems excessive. It's probably only used in the Cart but I haven't checked thoroughly so leaving it alone for now. Same for the admin.
Also
type="text/javascript"is no longer necessary.