Fix phpseclib class namespace in Varien_Io_Sftp #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: lib/Varien
fballiano
approved these changes
Feb 2, 2023
kiatng
reviewed
Feb 3, 2023
| @@ -117,7 +115,7 @@ public function rmdir($dir, $recursive = false) | |||
| $list = $this->_connection->nlist(); | |||
| if (!count($list)) { | |||
| // Go back | |||
| $this->_connection->chdir($pwd); | |||
| $this->_connection->chdir($cwd); | |||
There was a problem hiding this comment.
Is it better to change line 111 instead:
from $cwd = $this->_connection->pwd();
to $pwd = $this->_connection->pwd();
There was a problem hiding this comment.
I think pwd means "print working directory", and cwd means "current working directory". So cwd is the value resulting from calling pwd().
Flyingmana
approved these changes
Feb 3, 2023
fballiano
pushed a commit
that referenced
this pull request
Feb 4, 2023
|
merged and ported to 20.0 |
elidrissidev
added a commit
to elidrissidev/magento-lts
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
A small fix related to
phpseclib/phpseclibcomposer dependency which uses a different namespace than the one that was installed inlib/. I also removed the unneededrequire_oncefrom the top of the file, and corrected an undefined variable usage.Related Pull Requests
Contribution checklist (*)