Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set phpstan to bleedingEdge config #3011

Merged
merged 25 commits into from
Feb 28, 2023
Merged

Conversation

Flyingmana
Copy link
Contributor

there is a performance improvement for phpstan possible when switching to the currend bleedingEdge config.

https://phpstan.org/blog/phpstan-1-6-0-with-conditional-return-types#lower-memory-consumption

Heard about it while researching for a different project ( phpstan/phpstan#8813 )

Questions or comments

There are some incompatibilities mentioned, and while I checked I also saw that we get some errors.
Not sure yet about what needs to change, but for the future we will need to fix it anyway anywhen

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@elidrissidev
Copy link
Member

Nice, I noticed an improvement from 1:35 to only 40s when using the new configuration!

@github-actions github-actions bot added Component: CatalogSearch Relates to Mage_CatalogSearch Component: lib/Varien Relates to lib/Varien Component: lib/Mage Relates to lib/Mage Component: lib/* Relates to lib/* labels Feb 7, 2023
@elidrissidev
Copy link
Member

elidrissidev commented Feb 7, 2023

Fixed some phpstan issues, but some tricky ones popped up.

index.php Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Component: Wishlist Relates to Mage_Wishlist label Feb 18, 2023
@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Feb 18, 2023
@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Feb 18, 2023
@fballiano
Copy link
Contributor

fixed conflict with baseline by using 1.9.4.x baseline

@fballiano
Copy link
Contributor

guys, this is so incredibly much faster that I suggest we regenerate the baseline based on the code that's now in the PR and merge it. what do you think?

@github-actions github-actions bot added Component: Customer Relates to Mage_Customer Component: Tax Relates to Mage_Tax Component: Usa Relates to Mage_Usa labels Feb 27, 2023
@elidrissidev
Copy link
Member

Resolved some issues that were newly added to baseline since they were easy to fix.

fballiano
fballiano previously approved these changes Feb 27, 2023
@fballiano
Copy link
Contributor

@elidrissidev I lost your last comment, I guess that change was an older one (since this PR went thru many revisions), I've removed it, let's see if it works

Copy link
Member

@elidrissidev elidrissidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fballiano fballiano merged commit ab5f661 into OpenMage:1.9.4.x Feb 28, 2023
fballiano pushed a commit that referenced this pull request Feb 28, 2023
@fballiano
Copy link
Contributor

merged and v20ed

@elidrissidev
Copy link
Member

btw when you clear the description of the final squashed commit, be sure to keep the any special lines in it such as Signed-off-by,Co-authored-by, etc. Else that information will not appear on the merged commit

@fballiano
Copy link
Contributor

sorry, sometimes there's so much stuff in there that doesn't seem useful at all :-(

@elidrissidev
Copy link
Member

No problem :)

elidrissidev pushed a commit to elidrissidev/magento-lts that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Customer Relates to Mage_Customer Component: lib/Mage Relates to lib/Mage Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Sales Relates to Mage_Sales Component: Tax Relates to Mage_Tax Component: Usa Relates to Mage_Usa Component: Wishlist Relates to Mage_Wishlist phpstan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants