Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore addresses when country is not authorized #3019

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Ignore addresses when country is not authorized #3019

merged 1 commit into from
Apr 16, 2023

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Feb 9, 2023

Description

This PR hide not allowed countries when you create an order from backend.

image

Manual testing scenarios

  • For default configuration allow some countries
  • Create a customer and create multiple adresses (one per country)
  • For one of your store, update store configuration, allow one country
  • Try to create an order from backend with this customer with previous store
  • Without the PR: all adresses are visible, and with the PR: only addresses for allowed countries are displayed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Feb 9, 2023
@fballiano
Copy link
Contributor

I'd rebase this PR to 20.0

@luigifab
Copy link
Contributor Author

If you want... I'm lost with 19 and 20 branches.

@fballiano
Copy link
Contributor

OpenMage/rfcs#7 will be approved soon I hope so v19 will become frozen :-)

@luigifab luigifab changed the base branch from 1.9.4.x to main April 4, 2023 19:35
@fballiano fballiano merged commit e83b135 into OpenMage:main Apr 16, 2023
@luigifab luigifab deleted the address-orders branch April 16, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants