Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more info to admin auth exceptions #3024

Merged
merged 5 commits into from
Feb 26, 2023
Merged

Add more info to admin auth exceptions #3024

merged 5 commits into from
Feb 26, 2023

Conversation

loekvangool
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Component: Api2 Relates to Mage_Api2 label Feb 17, 2023
loekvangool and others added 2 commits February 17, 2023 11:59
@loekvangool @fballiano
Update app/code/core/Mage/Api2/Model/Auth/User/Admin.php
760f94d 
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
@loekvangool @fballiano
Update app/code/core/Mage/Api2/Model/Auth/User/Admin.php
54df6fe 
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
@elidrissidev
Copy link
Member

elidrissidev commented Feb 17, 2023 •
edited
Loading

Do you run into these exceptions often that you need to include more debugging info to the message? From a quick glance, I'm only able to find one reference of Mage_Api2_Model_Auth_User_Admin::setRole() and it's in the same file inside the condition block if (!$this->_role) {, so the exception shouldn't really be thrown.

@loekvangool
Copy link
Contributor Author

I have some kind of misconfiguration ATM from a 3rd party tool that uses our mage API. While tracking it down I got these messages on getRole(), not on setRole() but I spotted it and though why not add some TLC there as well.

@fballiano fballiano merged commit 35195f0 into OpenMage:1.9.4.x Feb 26, 2023
fballiano pushed a commit that referenced this pull request Feb 26, 2023
@loekvangool @fballiano
Added more info to admin auth API exceptions (#3024)
84fd691
@fballiano
Copy link
Contributor

merged and v20ed

elidrissidev pushed a commit to elidrissidev/magento-lts that referenced this pull request Feb 28, 2023
@loekvangool @elidrissidev
Added more info to admin auth API exceptions (OpenMage#3024)
ad55fe1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Api2 Relates to Mage_Api2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loekvangool @elidrissidev @fballiano @addison74