Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docblock related to customer address. #3035

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Feb 21, 2023

Description (*)

This PR is mainly to fix this error:

 * @method int getCountryId()

The method returns the 2-character country code. I put a bug in production today because I believed it.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Checkout Relates to Mage_Checkout Component: Customer Relates to Mage_Customer Template : base Relates to base template Template : rwd Relates to rwd template labels Feb 21, 2023
@fballiano fballiano merged commit 9657d9a into OpenMage:1.9.4.x Feb 21, 2023
@fballiano
Copy link
Contributor

merged anche cp to v20

@kiatng kiatng deleted the customer_address_docblock branch February 27, 2023 08:54
elidrissidev pushed a commit to elidrissidev/magento-lts that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Relates to Mage_Checkout Component: Customer Relates to Mage_Customer Template : base Relates to base template Template : rwd Relates to rwd template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants