Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed E_DEPRECATED in Mage/GoogleAnalytics/Block/Ga.php #3037

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Fixed E_DEPRECATED in Mage/GoogleAnalytics/Block/Ga.php #3037

merged 1 commit into from
Feb 22, 2023

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Feb 22, 2023

Description (*)

This shows up in my error log:

    [type] => 8192:E_DEPRECATED
    [message] => trim(): Passing null to parameter #1 ($string) of type string is deprecated
    [file] => .../app/code/core/Mage/GoogleAnalytics/Block/Ga.php
    [line] => 116
    [uri] => /customer/account/login/

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: GoogleAnalytics Relates to Mage_GoogleAnalytics label Feb 22, 2023
@fballiano fballiano merged commit 59f09f4 into OpenMage:1.9.4.x Feb 22, 2023
fballiano pushed a commit that referenced this pull request Feb 22, 2023
@kiatng @fballiano
Fixed E_DEPRECATED in Mage/GoogleAnalytics/Block/Ga.php (#3037)
75fac8a
@fballiano
Copy link
Contributor

merged and v20ed

@kiatng kiatng deleted the E_DEPRECATED_in_Ga branch February 27, 2023 08:54
elidrissidev pushed a commit to elidrissidev/magento-lts that referenced this pull request Feb 28, 2023
@kiatng @elidrissidev
Fixed E_DEPRECATED in Mage/GoogleAnalytics/Block/Ga.php (OpenMage#3037)
9a46af4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: GoogleAnalytics Relates to Mage_GoogleAnalytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiatng @fballiano @ADDISON74