Eav config cache followup for multi scope load #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in the same context due to entity type attribute collection being reused
fballiano
reviewed
Feb 25, 2023
luigifab
previously approved these changes
Mar 3, 2023
kiatng
reviewed
Mar 3, 2023
fballiano
reviewed
Mar 8, 2023
…ollection and for code reuse instead
…d' into eav_config_cache_multi_scope_load
fballiano
reviewed
Mar 9, 2023
|
Is it possible to get this merged, would make it easier to get the changes for #3057 committed and into a PR? |
fballiano
approved these changes
Mar 9, 2023
|
@luigifab could you check it again? |
when we get another green light I'll merge it right away. I keep commenting stuff cause I hate when PRs go sleepy. |
ADDISON74
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way
Mage_Eav_Model_Entity_Type::getAttributeCollectionreuses the collection and the fact thatAttribute_Collection::addStoreLabeldoes not support adding multiple stores at once it's impossible to load multiple stores attributes during the same context (page request, cli call, cron job, ...).This is a followup that adds a non-breaking bypass to this behaviour, allowing retrieval of a non-cache collection.
It also stops the API from sometimes loading more data then actually requested, due to the collection being modified (but this did not appear to break anything).
Related Pull Requests
#2993
Fixed Issues (if relevant)
Manual testing scenarios (*)