Enabled PHP 8.2 in composer.json, updated README with software compatibility info #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elidrissidev
approved these changes
Mar 2, 2023
kiatng
approved these changes
Mar 2, 2023
|
merged and v20ed |
|
I think that warning about the possible malfunction of some extensions should have been kept. We assume no responsibility if someone migrates to a PHP 8.x version and has trouble with 3rd party source code. |
|
I really think it’s something people should already know. Its like installing windows 11 without knowing that you may have issues with an old version of photoshop or something. |
|
Also, this readme is clearly written for developers, not end users, so they have to know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm testing OM with PHP8.2 and it works for me as good as 8.1, we should at least let people install OM via composer with 8.2.
This PR enables that and updates the README