Make Prototype Validator optional #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #3054 |
|
at a first glance it should be ok |
ADDISON74
approved these changes
Mar 9, 2023
fballiano
pushed a commit
that referenced
this pull request
Mar 10, 2023
|
merged and 20ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
I'm removing
prototype/validation.jsfrom some of my pages, but some shared JavaScript libs assume it's still there and start to generate errors.The validator is not necessary on every page, hence it should be possible to remove it without running into errors.
In the slightly longer term, I'd like to see the whole thing removed and instead switch to the new HTML5 validation options, which are plenty: https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation.