Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem with associated_products not visible in backend #3093

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Fixed problem with associated_products not visible in backend #3093

merged 4 commits into from
Mar 24, 2023

Conversation

fballiano
Copy link
Contributor

If you create a grouped product, when you associate some products to the grouped and save, they won't appear in the "associated products" tab.

This is because #2715 changed the lines that are reverted in this PR, switching the default value from null to [] and causing a series of other checks to fail.

With this PR the funcionality is working again.

Related Pull Requests

  1. Keep current selection for Related, Up-sells, Cross-sells, Associated grids #2715

Fixed Issues (if relevant)

  1. Fixes Associated product in admin not visible #3066

Manual testing scenarios (*)

  1. create a grouped product
  2. associate some other products
  3. save
  4. associated products are not shown (before the PR)

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Mar 15, 2023
addison74
addison74 previously approved these changes Mar 16, 2023
@kiatng
Copy link
Contributor

kiatng commented Mar 16, 2023

Doesn't this "unfix" the bug in issue #2715? How about only change this ->setProductsGrouped($this->getRequest()->getPost('products_grouped', null)); for grouped products?

@fballiano
Copy link
Contributor Author

i thought about that but all those methods are exactly the same, so I don't know.. it seemed better to have consistency between them no?

@fballiano
Copy link
Contributor Author

I didn't notice that this PR it's actually a complete revert of #2715

uff

the thing is we can't have the grouped products not working at all.

@fballiano
Copy link
Contributor Author

@kiatng I've reverted everything except the groupedProducts line, which make grouped products work for me again

@luigifab
Copy link
Contributor

There is a strange thing, without this, if you press reset filter, then all is working fine.

@fballiano
Copy link
Contributor Author

There is a strange thing, without this, if you press reset filter, then all is working fine.

@luigifab the "reset filter" button calls the "superGroupGridOnly" method which wasn't affected by #2715, that's why it still works :-)

kiatng
kiatng previously approved these changes Mar 18, 2023
kiatng
kiatng previously approved these changes Mar 20, 2023
@fballiano
Copy link
Contributor Author

without this one we can't close 19.5/20.1, grouped products are literally broken

@fballiano fballiano merged commit 49a2afa into OpenMage:1.9.4.x Mar 24, 2023
@fballiano fballiano deleted the associated_products branch March 24, 2023 14:53
@fballiano
Copy link
Contributor Author

merged and 20ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Associated product in admin not visible
4 participants