-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed problem with associated_products not visible in backend #3093
Conversation
Doesn't this "unfix" the bug in issue #2715? How about only change this |
i thought about that but all those methods are exactly the same, so I don't know.. it seemed better to have consistency between them no? |
I didn't notice that this PR it's actually a complete revert of #2715 uff the thing is we can't have the grouped products not working at all. |
@kiatng I've reverted everything except the groupedProducts line, which make grouped products work for me again |
There is a strange thing, without this, if you press reset filter, then all is working fine. |
without this one we can't close 19.5/20.1, grouped products are literally broken |
merged and 20ed |
If you create a grouped product, when you associate some products to the grouped and save, they won't appear in the "associated products" tab.
This is because #2715 changed the lines that are reverted in this PR, switching the default value from
null
to[]
and causing a series of other checks to fail.With this PR the funcionality is working again.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)