Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dev-meta-package to 1.0.2 #3111

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Bump dev-meta-package to 1.0.2 #3111

merged 2 commits into from
Mar 23, 2023

Conversation

fballiano
Copy link
Contributor

This should fix the PHPCS errors we're getting when workflows run.

@github-actions github-actions bot added the composer Relates to composer.json label Mar 22, 2023
@fballiano
Copy link
Contributor Author

I've no idea why it doesn't work

@elidrissidev
Copy link
Member

Seems like it's still installing the package from the old HEAD (OpenMage/dev-translations@cace35f):

- Installing openmage/dev-translations (dev-main cace35f): Extracting archive

I suspect a cache somewhere is causing this.

@elidrissidev
Copy link
Member

elidrissidev commented Mar 22, 2023

I think I found the problem, you need to explicitly update the translations package as well composer update openmage/dev-translations, because the old commit id is still being referenced from composer.lock.

@fballiano
Copy link
Contributor Author

to generate this PR I run exactly /usr/local/opt/php@7.4/bin/php /usr/local/bin/composer update openmage/dev-meta-package and if I run it again the diff is empty :-\

@elidrissidev
Copy link
Member

elidrissidev commented Mar 22, 2023

Oops sorry I meant openmage/dev-translations, updated my comment.

@fballiano
Copy link
Contributor Author

mmmm interesting, I did a /usr/local/opt/php@7.4/bin/php /usr/local/bin/composer update openmage/dev-translation but again no diff :-\

@elidrissidev
Copy link
Member

Weird, it's updating composer.lock for me when I run it:

Screen Shot 2023-03-22 at 5 45 55 PM

@fballiano
Copy link
Contributor Author

interesting, but it seems it downgrades dev-meta-package :-\

@elidrissidev
Copy link
Member

It's only doing that because I discarded the version upgrade of dev-meta-package from my composer.lock that I did a few minutes ago, it shouldn't do that normally. I'll try pushing the update.

@fballiano fballiano merged commit 8a6fa35 into OpenMage:1.9.4.x Mar 23, 2023
@fballiano fballiano deleted the devmetaupdate branch March 23, 2023 23:16
fballiano added a commit that referenced this pull request Mar 23, 2023
---------

Co-authored-by: Mohamed ELIDRISSI <67818913+elidrissidev@users.noreply.github.com>
@fballiano
Copy link
Contributor Author

merged and 20ed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer Relates to composer.json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants