Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Illegal offset type in Mage_Tag #3118

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Fixed Illegal offset type in Mage_Tag #3118

merged 2 commits into from
Mar 27, 2023

Conversation

m-overlund
Copy link
Contributor

@m-overlund m-overlund commented Mar 27, 2023 •
edited
Loading

Update: Occurs when using https://github.com/tzyganu/EasylifeTag
So maybe not the best fix, when tags without this extension is called via Id instead of a string.

EasylifeTag:
What it does

It changes the urls for tag pages from tag/product/list/tagId/10 to tag/clothes.

Description (*)

When clicking a Tag on frontend the site returns an error - HTTP 500.

Manual testing scenarios (*)

  1. Install https://github.com/tzyganu/EasylifeTag
  2. create a Tag
  3. Click in on the frontend

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@m-overlund
Tag: fixes Illegal offset type in Tags
a0dc6bd 
When clicking a Tag on frontend, when using PHP8.1 - the page crashes and throws a typeError:
`TypeError: Illegal offset type`
@github-actions github-actions bot added the Component: Tag Relates to Mage_Tag label Mar 27, 2023
fballiano
fballiano approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and makes sense cause the getPart(Zend_Db_Select::ORDER) should anyway return an array of strings

@fballiano fballiano changed the title Tag: fixes Illegal offset type in Tags Fixed Illegal offset type in Mage_Tag Mar 27, 2023
@fballiano fballiano merged commit 28db818 into OpenMage:1.9.4.x Mar 27, 2023
fballiano added a commit that referenced this pull request Mar 27, 2023
@m-overlund @fballiano
Fixed Illegal offset type in Mage_Tag (#3118)
db30481 
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
@fballiano
Copy link
Contributor

merge and 20ed

@m-overlund m-overlund deleted the patch-1 branch April 13, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: Tag Relates to Mage_Tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-overlund @fballiano @ADDISON74