Avoided unnecessary calls to string translation methods for catalog/sales rules labels #3140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR stop translations of rules labels from frontend.
Perhaps the best way is to remove all translations from model, and translate only from blocks? I don't know.
Here a before/after with Blackfire with a cart with ~50 products (simple, configurable, bundles):
original (before):
after without the static property:
after:
Can fix partially #3127 or not.
Tested with PHP 8.0 and 8.2 with OM rc2.
If you have others modules or custom dev, that do the same, you need to update your files to have better performance on your website. Example with HiPay module's.
Contribution checklist