Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerated PHPStan baseline for "main" branch #3142

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Regenerated PHPStan baseline for "main" branch #3142

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e49f7c8
first round
fballiano Apr 4, 2023
ba96cca
second round
fballiano Apr 4, 2023
8519752
third round
fballiano Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 15 additions & 50 deletions phpstan.dist.baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ parameters:
count: 1
path: app/code/core/Mage/Admin/Model/Resource/User.php

-
message: "#^Return type \\(bool\\) of method Mage_Admin_Model_Resource_User\\:\\:delete\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Abstract\\:\\:delete\\(\\)$#"
count: 1
path: app/code/core/Mage/Admin/Model/Resource/User.php

-
message: "#^Call to an undefined method Mage_Admin_Model_Resource_Roles\\:\\:update\\(\\)\\.$#"
count: 1
Expand Down Expand Up @@ -575,11 +570,6 @@ parameters:
count: 1
path: app/code/core/Mage/Api/Model/Resource/Roles.php

-
message: "#^Return type \\(bool\\) of method Mage_Api_Model_Resource_User\\:\\:delete\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Abstract\\:\\:delete\\(\\)$#"
count: 1
path: app/code/core/Mage/Api/Model/Resource/User.php

-
message: "#^Call to an undefined method Mage_Api_Model_Resource_Roles\\:\\:update\\(\\)\\.$#"
count: 1
Expand Down Expand Up @@ -1135,6 +1125,11 @@ parameters:
count: 3
path: app/code/core/Mage/Catalog/Helper/Product.php

-
message: "#^Method Mage_Catalog_Helper_Product\\:\\:getMinimalQty\\(\\) should return int\\|null but returns float\\.$#"
count: 1
path: app/code/core/Mage/Catalog/Helper/Product.php

-
message: "#^Ternary operator condition is always true\\.$#"
count: 1
Expand Down Expand Up @@ -1320,11 +1315,6 @@ parameters:
count: 1
path: app/code/core/Mage/Catalog/Model/Factory.php

-
message: "#^Comparison operation \"\\=\\=\" between Mage_Catalog_Model_Resource_Eav_Attribute and 1 results in an error\\.$#"
count: 1
path: app/code/core/Mage/Catalog/Model/Layer/Filter/Attribute.php

-
message: "#^Parameter \\#2 \\$filterBlock \\(Varien_Object\\) of method Mage_Catalog_Model_Layer_Filter_Attribute\\:\\:apply\\(\\) should be compatible with parameter \\$filterBlock \\(null\\) of method Mage_Catalog_Model_Layer_Filter_Abstract\\:\\:apply\\(\\)$#"
count: 1
Expand Down Expand Up @@ -1360,6 +1350,11 @@ parameters:
count: 1
path: app/code/core/Mage/Catalog/Model/Product.php

-
message: "#^Property Mage_Catalog_Model_Product\\:\\:\\$_stockItem \\(Mage_CatalogInventory_Model_Stock_Item\\) does not accept Varien_Object\\.$#"
count: 1
path: app/code/core/Mage/Catalog/Model/Product.php

-
message: "#^Property Mage_Catalog_Model_Product\\:\\:\\$_typeInstance \\(Mage_Catalog_Model_Product_Type_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#"
count: 1
Expand Down Expand Up @@ -1510,11 +1505,6 @@ parameters:
count: 1
path: app/code/core/Mage/Catalog/Model/Resource/Category.php

-
message: "#^Property Mage_Catalog_Model_Resource_Category\\:\\:\\$_isActiveAttributeId \\(int\\) does not accept string\\|false\\|null\\.$#"
count: 1
path: app/code/core/Mage/Catalog/Model/Resource/Category.php

-
message: "#^Property Mage_Catalog_Model_Resource_Category\\:\\:\\$_storeId \\(int\\) on left side of \\?\\? is not nullable\\.$#"
count: 1
Expand Down Expand Up @@ -1790,11 +1780,6 @@ parameters:
count: 1
path: app/code/core/Mage/CatalogSearch/Model/Advanced.php

-
message: "#^Return type \\(bool\\) of method Mage_CatalogSearch_Model_Layer_Filter_Attribute\\:\\:_getIsFilterableAttribute\\(\\) should be compatible with return type \\(Mage_Catalog_Model_Resource_Eav_Attribute\\) of method Mage_Catalog_Model_Layer_Filter_Attribute\\:\\:_getIsFilterableAttribute\\(\\)$#"
count: 1
path: app/code/core/Mage/CatalogSearch/Model/Layer/Filter/Attribute.php

-
message: "#^If condition is always true\\.$#"
count: 1
Expand Down Expand Up @@ -2025,11 +2010,6 @@ parameters:
count: 1
path: app/code/core/Mage/Core/Helper/String.php

-
message: "#^If condition is always true\\.$#"
count: 1
path: app/code/core/Mage/Core/Model/Abstract.php

-
message: "#^Property Mage_Core_Model_Abstract\\:\\:\\$_cacheTag \\(string\\|true\\) does not accept default value of type false\\.$#"
count: 1
Expand Down Expand Up @@ -2675,16 +2655,6 @@ parameters:
count: 1
path: app/code/core/Mage/Directory/Model/Currency/Import/Webservicex.php

-
message: "#^Method Mage_Downloadable_Block_Adminhtml_Catalog_Product_Edit_Tab_Downloadable_Links\\:\\:getPurchasedSeparatelyAttribute\\(\\) should return Mage_Catalog_Model_Resource_Eav_Attribute but returns Mage_Eav_Model_Entity_Attribute\\.$#"
count: 1
path: app/code/core/Mage/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php

-
message: "#^Property Mage_Downloadable_Block_Adminhtml_Catalog_Product_Edit_Tab_Downloadable_Links\\:\\:\\$_purchasedSeparatelyAttribute \\(Mage_Catalog_Model_Resource_Eav_Attribute\\|null\\) does not accept Mage_Eav_Model_Entity_Attribute\\.$#"
count: 1
path: app/code/core/Mage/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php

-
message: "#^Left side of && is always true\\.$#"
count: 1
Expand Down Expand Up @@ -2755,21 +2725,11 @@ parameters:
count: 1
path: app/code/core/Mage/Eav/Model/Config.php

-
message: "#^Cannot call method loadByCode\\(\\) on Mage_Core_Model_Abstract\\|false\\.$#"
count: 1
path: app/code/core/Mage/Eav/Model/Config.php

-
message: "#^Method Mage_Eav_Model_Config\\:\\:getAttribute\\(\\) should return Mage_Eav_Model_Entity_Attribute_Abstract\\|false but returns Mage_Eav_Model_Entity_Attribute_Interface\\.$#"
count: 1
path: app/code/core/Mage/Eav/Model/Config.php

-
message: "#^Negated boolean expression is always true\\.$#"
count: 1
path: app/code/core/Mage/Eav/Model/Config.php

-
message: "#^Method Mage_Eav_Model_Convert_Adapter_Entity\\:\\:_getCollectionForLoad\\(\\) should return Mage_Eav_Model_Entity_Collection but returns Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#"
count: 1
Expand Down Expand Up @@ -3880,6 +3840,11 @@ parameters:
count: 1
path: app/code/core/Mage/Sales/Model/Order/Invoice.php

-
message: "#^Property Mage_Core_Model_Abstract\\:\\:\\$_origData \\(array\\) does not accept null\\.$#"
count: 1
path: app/code/core/Mage/Sales/Model/Order/Invoice.php

-
message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getForceApplyDiscountToParentItem\\(\\)\\.$#"
count: 1
Expand Down