Moved isCurrentlySecure() method to Mage_Core_Model_App #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cked without full config load (before store is initialized).
fballiano
reviewed
May 9, 2023
fballiano
previously approved these changes
May 9, 2023
addison74
previously approved these changes
May 9, 2023
fballiano
previously approved these changes
May 9, 2023
fballiano
reviewed
May 9, 2023
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
fballiano
approved these changes
May 9, 2023
|
I merged to speed things up just because it already had 2 green checks and there were 2 minor docblock changes after that, but still all checks are ok. |
fballiano
changed the title
isCurrentlySecure to be che…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I brushed the dust off of Cm_Diehard and it seems it was broken by one of my own PRs (#1462).. When generating the cache key before the full init, it checks the request scheme which tries to load the store which hasn't been initialized yet so throws
Mage_Core_Model_Store_Exception.This PR moves the
isCurrentlySecuremethod (and keeps the old one as a wrapper for BC) toMage_Core_Model_Appso that it can be called earlier in the request cycle without causing aMage_Core_Model_Store_Exception. I don't know if any other modules require this but there is no regression.I also added a comment to "Offloader header" to clarify it's utility.
Just for kicks, here are the results with the "Local" backend on a clean installation with
Cm_DiehardSample(Cm_Diehardon the left, no FPC on the right):