Added PHP8 configurations to .htaccess #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addison74
approved these changes
May 14, 2023
|
There are several simple PRs like this one that still need an approval to be integrated. Do we send special invitations to a few? |
|
@addison74 please feel free, I don't always do that because I don't always want to overwhelm the few active people we have :-( |
addison74
requested review from
colinmollenhour,
Flyingmana,
kiatng,
sreichel,
luigifab and
elidrissidev
elidrissidev
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies php7 settings to php8 in our htaccess file, it was reported in #3252 and follows #2306
there was a question, is it mod_php.c or mod_php8.c but I've tested that mod_php.c works and that's what also magento 2 uses (you could check in their repo)
Fixed Issues