-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions - check-files
workflow - split into steps as a workaround for step template size limit
#3276
GitHub Actions - check-files
workflow - split into steps as a workaround for step template size limit
#3276
Conversation
hi @gorbunovav and thanks for your PR, could you rebase it on the "main" branch? |
…nto steps as a workaround for step template size limit
84e47a0
to
7c9e8e3
Compare
@fballiano done |
You may add yourself to the list of contributors, if your name doesn't appear yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the output of this PR.
everything seems ok but I don't have the knowledge on this topic to test it properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought error came from previous step ...
Split grep commands into steps does not hurt ... untested,
I guess we've no real way to test it so let's merge it, since it is approved, and see |
Description (*)
Splits
check-files
job into more steps to workaround the template size limit issue.Fixed Issues (if relevant)
Fixes #3275
Manual testing scenarios (*)
check-files
job has completed succesfully and emits relevant output valuesContribution checklist (*)