Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mage_Rules now truncates strings after 100 characters instead of 33 in the backend #3288

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

loekvangool
Copy link
Contributor

We have more pixies than in 2008

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

We have more pixies than in 2008
@github-actions github-actions bot added the Component: Rule Relates to Mage_Rule label May 30, 2023
@kiatng
Copy link
Contributor

kiatng commented May 31, 2023

It'll be nice to attach a screenshot of before/after.

@loekvangool
Copy link
Contributor Author

I hesitate to show anything sensitive, so here goes

image

image

@addison74
Copy link
Contributor

I did not think that there could be a limitation in this regard, as long as the conditions I used over the years were 1 to 4. But if it is a problem then it must be changed, I think that a value of 50 would be more appropriate.

However, this limitation to 33 was not established taking into account the non-affecting of the performance?

Increase truncation of rule string to length 100 from 30.
@github-actions github-actions bot added the JavaScript Relates to js/* label Jun 1, 2023
Edit style.
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to commit rules.js to increase the truncate size while editing the rule. Tested with length 100, seems ok to me.

@fballiano fballiano changed the title Allow longer rule string Mage_Rules now truncates strings after 100 characters instead of 33 in the backend Jun 1, 2023
@fballiano fballiano merged commit 7f2d82b into OpenMage:main Jun 1, 2023
@loekvangool loekvangool deleted the patch-4 branch June 1, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Rule Relates to Mage_Rule JavaScript Relates to js/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants