-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Google Analytics3 and Universal Analytics #3347
Conversation
If this gets approved I'd like to add GoogleTagManager to OM. |
this PR and #3347 (comment) are important cause at the moment website with GTM can't have enhanced ecommerce data with analytics4 |
@empiricompany what do you think? |
I agree to discontinue the unsupported analytics platform. GTM is just a simple script that can be added in configuration design html scripts, it doesn't do anything on its own. Instead, I wanted to add support for the AdWords tag for conversion tracking. |
yes, but I want to have GTM/analytics selection and not just ga4, since I've already 2 customers that have GTM and, with rc5, can't really use enhanced ecommerce data :-) thank you anyway, I'll work on a PR ASAP and let's see! |
merging per 1green + 2grays, thank you! |
ok but you want to add GTM as alternative to gtag and compile the data layer for ecommerce too or in addition for simply add a container for GTM scripts? |
@empiricompany I wanted to have the GTM container instead of the ga4 script, then call the gtag funcion for the enhanced ecommerce. it should work if the gtag is injected by GTM no? am I missing something? |
yes, then we have to simple add new option to inject gtm instead of gtag |
Since Google is discontinuing Analytics3 and UniversalAnalytics (https://support.google.com/analytics/answer/11583528?hl=en) I thought that maybe this PR could be ok, removing almost everything related to those 2 services.
I thought to target
main
, we could targetnext
instead but I don't think it's really necessary since these features will be useless anyway in a few days.I've also removed the install script since it was forcing the usage of analytics3, which would be wrong anyway.