-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added hidden element before multiselect form elements in adminhtml #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: lib/Varien
Relates to lib/Varien
Component: lib/*
Relates to lib/*
labels
Jun 26, 2023
kiatng
reviewed
Jun 27, 2023
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
2023-07-04.09-46-38.mp4 |
mmm ok I got it, if you first unselect some values (but not all) and save, then unselect everything and save again, then it works. but unselecting everything at the first round and saving doesn't work |
fballiano
reviewed
Jul 4, 2023
fballiano
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, works perfectly
kiatng
approved these changes
Jul 6, 2023
fballiano
changed the title
Multiselect needs hidden element even when disabled by storeView
Added hidden element before multiselect form elements in adminhtml
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This makes it possible for a Multiselect EAV Attribute to set no values inside a store view while the global settings still has values.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)