Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed logException twice in CartController.php #3354

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Jun 27, 2023

Description (*)

See line 226

public function addException(Exception $exception, $alternativeText)
{
Mage::logException($exception);
$this->addError($alternativeText);
return $this;
}

The exception is logged, no need to do it twice.

I searched and checked the entire repo, it seems this only happens in CartController.php.

@github-actions github-actions bot added the Component: Checkout Relates to Mage_Checkout label Jun 27, 2023
@fballiano fballiano merged commit f43a033 into OpenMage:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Relates to Mage_Checkout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants