Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #3692, fatal error on saving empty tier price. #3693

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Dec 7, 2023

Description (*)

Everything is explained in issue #3692.

Fixed Issues (if relevant)

  1. Fixes Fatal error on saving a magento product #3692

@kiatng kiatng added the PHP 8 Related to PHP8 label Dec 7, 2023
@fballiano
Copy link
Contributor

I wonder why the heck it was done with the "* 1" notation :-\

@fballiano fballiano merged commit 86d2174 into OpenMage:main Dec 7, 2023
17 checks passed
@addison74
Copy link
Contributor

There are over 16.000 PHP files in OpenMage, who knows how many such logical errors there are. We are lucky that there are people who encounter problems and that's how we learn about them. No product is perfect ...

@kiatng kiatng deleted the 3692_tierprice_bug branch August 26, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8 Related to PHP8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error on saving a magento product
4 participants