Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes different width of input fields, see #3716 #3740

Closed
wants to merge 2 commits into from
Closed

Fixes different width of input fields, see #3716 #3740

wants to merge 2 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 21, 2024

Description (*)

  • changed width to 330px for textarea, text & select fields
  • updated README.md

Fixed Issues (if relevant)

  1. Fixes Magento Admin: Input fields text and select drop-downs are different widths in "Attribute Information" page #3716

Questions or comments

Only tested with modern admin theme. Maybe can improved for all other SCSS files (untested).

- changed with to 330px for textarea, text & select fields
- updated README.md
@github-actions github-actions bot added documentation Template : admin Relates to admin template Component: Adminhtml Relates to Mage_Adminhtml labels Jan 21, 2024
@sreichel
Copy link
Contributor Author

sreichel commented Jan 24, 2024

Note: i only changed the SCSS-file. Everything else - order selectors - was made autotically.

@fballiano
Copy link
Contributor

tested, seems to me to work fine, I wouldn't add the filewatcher section to the readme tho since it's used by an extreme minority or people

@sreichel
Copy link
Contributor Author

Added readme section to provide to provide some basic information to work with scss files.

Which tool do you use?

@fballiano
Copy link
Contributor

I used either compass or the normal sass cli command, but my comment was only about having the phpstorm helper in the readme, at the end of the day if somebody has to touch the sass files they can run sass in CLI. it's just cause the readme is becoming huge and we already noticed many people don't read it, so adding more info (expecially if it's not of wide use) could be counterproductive

@pquerner
Copy link
Contributor

I acutually like the comment in the readme. Its for developers, afterall.

@sreichel
Copy link
Contributor Author

sreichel commented Jan 26, 2024

@fballiano i've used compass in the past too, but faced problems with different ruby packages.

  1. different tools may cause different css-output
  2. i had to setup new PhpStorm and struggeled with correct config to write css to the right place (thats why i added it - just as a reminder)

IMHO the readme is already to large ... maybe consider #3659 to be merged.

edit; install pyhthon, mkdocs, ... is only for local preview, hosting at github.io works out of the box

@sreichel
Copy link
Contributor Author

sreichel commented Feb 3, 2024

I acutually like the comment in the readme. Its for developers, afterall.

Wd like to keep it too.

Btw ... also fixes system-config fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magento Admin: Input fields text and select drop-downs are different widths in "Attribute Information" page
4 participants