Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused file js/mage/adminhtml/image.js #3758

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

fballiano
Copy link
Contributor

In the process of reviewing every javascript file, in order to rewrite everything without prototypejs, I found this image.js file that seems to be unused, I couldn't find any place where this file is linked and, removing it, I couldn't find any broken funcionality

@github-actions github-actions bot added the JavaScript Relates to js/* label Jan 25, 2024
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find any reference too. OM has no image resize and rotate in the backend.

@fballiano fballiano merged commit 5d35a2d into OpenMage:next Jan 27, 2024
1 check passed
@fballiano fballiano deleted the imagejs branch January 27, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScript Relates to js/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants