Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed "unload" to "beforeunload" in extjs to avoid deprecation warning in developer console #3853

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

andrewcbi
Copy link
Contributor

@andrewcbi andrewcbi commented Feb 25, 2024

Description (*)

Updated the unload calls to be beforeunload in extjs (removes deprecation warning in chrome console).

Manual testing scenarios (*)

  1. Open console in chrome when in backend admin section.
  2. Deprecated feature warning will be shown.
  3. With this change the warning related to extjs no longer appears.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the JavaScript Relates to js/* label Feb 25, 2024
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and couldn't see any problem

@ADDISON74
Copy link
Contributor

The description is not exactly suitable for the way of reproducing the error. Let's rephrase it.

If we access Backend > CMS then we edit any page, in the tab Issues it is displayed the following breaking change:

Deprecated feature used
Unload event listeners are deprecated and will be removed.
1 source
prototype.js:7020

screenshot

Applying this PR the message is no longer displayed.

PS - In the future, when you create a new branch for a PR, please don't call it "main".

@fballiano fballiano changed the title change unload to beforeunload in extjs Changed "unload" to "beforeunload" in extjs to avoid deprecation warning in developer console Feb 25, 2024
@fballiano fballiano merged commit 9f85ccd into OpenMage:main Feb 25, 2024
14 checks passed
@andrewcbi andrewcbi deleted the main branch February 25, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScript Relates to js/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants