Rewrote js/varien/menu.js without prototypejs but no longer linked in the base theme
#3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Template : rwd
fballiano
requested review from
Flyingmana,
kiatng,
ADDISON74,
luigifab and
aterjung
kiatng
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets
nextThis menu.js is an ancient way of doing "hover", it's not used by
RWDand it's linked inbasebut obviously base doesn't even have a styling so it's kinda useless there.My original idea was to remove this file altogether but I've thought not to do that at the moment.
I've rewritten (and tested) this file without prototypejs and without ie6 code.
I've then removed the "linking" of this file within the
basetheme because, in the future, this unneeded way of dealing with hover should be removed altogether