Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrote js/mage/adminhtml/accordion.js without prototypejs #3947

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Rewrote js/mage/adminhtml/accordion.js without prototypejs #3947

merged 1 commit into from
Apr 22, 2024

Conversation

fballiano
Copy link
Contributor

This PR targets next

To test this (I've tested and found no problem):

  • open backend, catalog -> products, then open the tab "product alerts", the content of the page are 2 accordions
  • open backend, customers -> manage customers, recent orders, shopping cart and wishlist are accordions (using ajax too)

@github-actions github-actions bot added the JavaScript Relates to js/* label Apr 21, 2024
@fballiano fballiano changed the title Rewrote js/mage/adminhtml/accordion.js without prototypejs Rewrote js/mage/adminhtml/accordion.js without prototypejs Apr 21, 2024
andrewcbi
andrewcbi approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@andrewcbi andrewcbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have tested and works as expected. thank you

@fballiano fballiano merged commit 4867631 into OpenMage:next Apr 22, 2024
14 checks passed
@fballiano fballiano deleted the rewroteaccordionjs branch April 22, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewcbi andrewcbi andrewcbi approved these changes

Assignees
No one assigned
Labels
JavaScript Relates to js/*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fballiano @andrewcbi