Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preliminary PHP 8.4 support: Fixed implicitly nullable parameter deprecation warning #4037

Merged
merged 11 commits into from
Jun 27, 2024
Merged

Preliminary PHP 8.4 support: Fixed implicitly nullable parameter deprecation warning #4037

merged 11 commits into from
Jun 27, 2024

Conversation

F1Red5
Copy link
Contributor

@F1Red5 F1Red5 commented Jun 9, 2024

@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Reports Relates to Mage_Reports Component: Checkout Relates to Mage_Checkout Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Customer Relates to Mage_Customer Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Admin Relates to Mage_Admin Component: Shipping Relates to Mage_Shipping Component: Rule Relates to Mage_Rule Component: Review Relates to Mage_Review Component: Payment Relates to Mage_Payment Component: Oauth Relates to Mage_Oauth Component: Newsletter Relates to Mage_Newsletter Component: CatalogIndex Relates to Mage_CatalogIndex Component: Api2 Relates to Mage_Api2 Component: Dataflow Relates to Mage_Dataflow Component: lib/* Relates to lib/* composer Relates to composer.json php-cs-fixer ddev labels Jun 9, 2024
@luigifab luigifab added the PHP 8.4 Relatee to PHP 8.4 label Jun 9, 2024
@F1Red5 F1Red5 changed the title Prepare for php8.4 PHP 8.4: Implicitly nullable parameter declarations deprecated Jun 10, 2024
@fballiano
Copy link
Contributor

isn't modifying public method a breaking change?

@Flyingmana
Copy link
Contributor

I did not look through all of them yet, but if it only makes existing parameters nullable, which already use Null as default value, thats not likely to break anything.

@fballiano
Copy link
Contributor

but if they were overridden by some 3rd party code, the method signature changes and the user would get a warning/error no?

@Flyingmana
Copy link
Contributor

Flyingmana commented Jun 24, 2024 •
edited
Loading

seems to be fine
https://3v4l.org/IKDae

mixed up the order
https://3v4l.org/THVfA

@fballiano
Copy link
Contributor

ok I've also done some tests and the core of this PR is ok, but it has too much stuff, it adds rector and polifys that are not related to the PR itself, so I will remove those parts and only keep the "inplicitly nullable" part

@github-actions github-actions bot removed the ddev label Jun 27, 2024
@fballiano fballiano changed the title PHP 8.4: Implicitly nullable parameter declarations deprecated Preliminary PHP 8.4 support: Fixed implicitly nullable parameter deprecation warning Jun 27, 2024
@fballiano fballiano merged commit a7a1bd6 into OpenMage:main Jun 27, 2024
18 checks passed
@sreichel sreichel deleted the prepare-php8.4 branch June 28, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Newsletter Relates to Mage_Newsletter Component: Oauth Relates to Mage_Oauth Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: Shipping Relates to Mage_Shipping Component: Usa Relates to Mage_Usa composer Relates to composer.json PHP 8.4 Relatee to PHP 8.4 php-cs-fixer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@F1Red5 @fballiano @Flyingmana @luigifab @sreichel