-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added check for isModuleOutputEnabled('Mage_Review') in customer's backend page #4075
Added check for isModuleOutputEnabled('Mage_Review') in customer's backend page #4075
Conversation
Any steps to reproduce the issue? |
The module Mage_Review is disabled. However, the link to it still appears. And when I click on it it generates an error. |
VARIANT 1 If I am accessing a customer account in the Backend, the [Product Reviews] tab is there. If I click on it I am seeing the fatal error bellow VARIANT 2 Both variants are producing wrong behaviors related to the Review module. Now lets test both variants with this PR applied Variant 1: Disabling the module by editing the xml file the [Product Reviews] tab doesn't appear anymore. This PR fixes the issue. Variant 2: Disabling the output of the module, the [Product Reviews] tab should not be visible in the customer account, but it is still there. If I am not wrong this needs a fix too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks to @kiatng suggestion it works for all cases now
With the last change both scenarios mention in my post are solved. We can merge it. |
Added validation for module Mage_Review in customer management ...