Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for isModuleOutputEnabled('Mage_Review') in customer's backend page #4075

Merged

Conversation

eneiasramos
Copy link
Contributor

@eneiasramos eneiasramos commented Jul 3, 2024

Added validation for module Mage_Review in customer management ...

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Jul 3, 2024
@addison74
Copy link
Contributor

Any steps to reproduce the issue?

@eneiasramos
Copy link
Contributor Author

@addison74

The module Mage_Review is disabled. However, the link to it still appears. And when I click on it it generates an error.

image

@addison74
Copy link
Contributor

addison74 commented Jul 6, 2024

VARIANT 1
In order to disable the Review module I edited the file /app/etc/modules/Mage_Review.xml, but the Rating module depends on it, so I disable it too.

If I am accessing a customer account in the Backend, the [Product Reviews] tab is there. If I click on it I am seeing the fatal error bellow

fatal_error

VARIANT 2
Disabling the Review module output in the Backend > System > Configuration > Advanced, in the customer account page the [Product Reviews] tab is there and loads all reviews.

Both variants are producing wrong behaviors related to the Review module.

Now lets test both variants with this PR applied

Variant 1: Disabling the module by editing the xml file the [Product Reviews] tab doesn't appear anymore. This PR fixes the issue.

Variant 2: Disabling the output of the module, the [Product Reviews] tab should not be visible in the customer account, but it is still there. If I am not wrong this needs a fix too.

Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks to @kiatng suggestion it works for all cases now

@fballiano fballiano changed the title Added validation for module Mage_Review in customer management Added check for isModuleOutputEnabled('Mage_Review') in customer's backend page Jul 7, 2024
@addison74
Copy link
Contributor

With the last change both scenarios mention in my post are solved. We can merge it.

@fballiano fballiano merged commit 594c640 into OpenMage:main Jul 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants