Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated TinyMCE to 6.8.4 #4084

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Updated TinyMCE to 6.8.4 #4084

merged 1 commit into from
Jul 5, 2024

Conversation

fballiano
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the JavaScript Relates to js/* label Jul 5, 2024
@addison74
Copy link
Contributor

Only 33 files? The last update v6.8.2 changed 99 files.

@fballiano
Copy link
Contributor Author

https://github.com/OpenMage/magento-lts/pull/3837/files was 47 files because it had the languages, but the update is so extremely minor

@addison74
Copy link
Contributor

Tthank you for the clarification. The upgrade to v6 of this editor was huge step and important change in OpenMage. I like how it looks and I appreciate that I didn't find any errors in the browser console. The buttons are well chosen and logically positioned, as are the menus. Great job.

@fballiano
Copy link
Contributor Author

:-) I guess we'll stay with 6.8 for another 10 years ehhehe

@fballiano fballiano merged commit 7ec8830 into OpenMage:main Jul 5, 2024
14 checks passed
@fballiano fballiano deleted the tinymce684 branch July 5, 2024 22:17
@addison74
Copy link
Contributor

@fballiano - Did you use 6.8.4 or 6.8.3 in this PR? I am asking this because from Help > Help > Version it says I am using TinyMCE 6.8.3. Please see bellow

tinymce

If you used 6.8.4 the guys from TinyMCE missed to change the version value.

@fballiano
Copy link
Contributor Author

6.8.3 was already in openpage before, try with some ctrl+f5 ;-)

@addison74
Copy link
Contributor

You are right. I should check with Firefox too. In Chrome I have the cache disable but I have to reload the page 2 times to get the new content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScript Relates to js/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants