Fixed invisible configuration values in backend

[fballiano]

The issue is perfectly explained by @ADDISON74 in #3583 (comment)

Instead of re-adding the text-shadow back I would change the color of the disabled items to #202856, which is the same color used for the other items in the configuration pages.

what do you think?

screenshot after this PR applied:

[ADDISON74]

In the legacy theme, the background color of an option is rgb(206, 206, 206) = #CECECE. For choosing the right text color we have to use a shades generator like this one (I set it up to 16 shades)

https://mdigi.tools/color-shades/#cecece

From #080808 to #787878 and making a few tests I think #585858 is the one. This is how it looks like

[fballiano]

good catch, what do you think about #999?

I tried it only because it was already used in the CSS and it's usually better not to have too many colors.

I've done it for the legacy and the new theme now if that's ok for you

[ADDISON74]

#999 is used in CSS, but here we have to refer to the elements we want to change. The background and color of the text. We clearly do not change the background and the color of the text must be related to the background in order to achieve a pleasing differentiation for the eyes. This way we can get rid of the addition of the shadow.

You have to choose a value in that range of shades. If you compare my image with yours, you will feel a balance of colors in mine. I have no merit in this, I just followed one of the rules for choosing color pallets.

[kiatng]

Agree to reuse existing color.

[ADDISON74]

Agree to reuse existing color.

If this statement will be a rule, then it means that we could use any other colors that can be found in the CSS file. My opinion remains unchanged, on a page the colors to be added to certain HTML elements are either the existing ones on the page, shades of the existing ones, or new ones in the color palette (adjacent, complementary, triadic, ...).

[fballiano]

when we talk about important elements, usually it's good to have as few colors as possible, one for text, one for disabled text, one for primary buttons etc, that's more or less what all css frameworks do and it's done for easiness of understanding from the brain.

IMHO the color you proposed is a bit too visible to be a disabled color, imho it kinda doesn't seem disabled to me.

[ADDISON74]

IMHO the color you proposed is a bit too visible to be a disabled color, imho it kinda doesn't seem disabled to me.

I proposed a color arguing how I chose it, by reference to the UI rules. Based on that rule, the color wanted by the majority could be reached, if the one chosen by me is not suitable.

[ADDISON74]

If you still want to reuse an existing color, then I propose to use the color of the text that does not have a background, in the images bellow, the one in the "First Day of Week" option, which is #969696.

This is how it looks before

This is how it looks after

[fballiano]

maybe it's a browser/OS difference because I used exactly that element to generate the 999, and in my browser I see

and 153,153,153 gets converted to 999

😱 I don't know why we're seing different things

[ADDISON74]

I am using Chrome/Windows 11.

select:disabled {
color: light-dark (graytext, rgb(170, 170, 170));
}

It is "user agent stylesheet". Using the color picker the color value is "#969696".

[fballiano]

ok, weird that they're different, anyway in the legacy css, if i'm not wrong, there's no 969696, while there are multple 999

[ADDISON74]

It will remain #999, although I would have wanted a shade relative to the background color.