Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error directory to checks + php8.4 fix #4184

Merged
merged 8 commits into from
Sep 9, 2024
Merged

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 5, 2024

Test php8.4 syntax.

   ! find . -not \( -path ./.phpstorm.meta.php -prune \) -type f -name "*.php" -exec php -d error_reporting=32767 -l {} \; 2>&1 1> /dev/null | grep "^"
  shell: /usr/bin/bash -e {0}
  env:
    COMPOSER_PROCESS_TIMEOUT: 0
    COMPOSER_NO_INTERACTION: 1
    COMPOSER_NO_AUDIT: 1
PHP Deprecated:  Error_Processor::_setSkin(): Implicitly marking parameter $config as nullable is deprecated, the explicit nullable type must be used instead in ./errors/processor.php on line 504

@github-actions github-actions bot added environment errors Relates to error pages phpstan labels Sep 5, 2024
addison74
addison74 previously approved these changes Sep 5, 2024
@github-actions github-actions bot added the phpcs label Sep 5, 2024
@sreichel sreichel changed the title Fixed PHP8.4 deprecated warning in Error_Processor Added error directory to checks + php8.4 fix Sep 5, 2024
kiatng
kiatng previously approved these changes Sep 6, 2024
addison74
addison74 previously approved these changes Sep 6, 2024
@sreichel sreichel dismissed stale reviews from addison74 and kiatng via 725be5d September 6, 2024 15:12
@kiatng kiatng merged commit 1ccc459 into OpenMage:main Sep 9, 2024
18 checks passed
@sreichel sreichel deleted the php84 branch September 9, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants