Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some event-prefixes, ref #249 #423

Closed
wants to merge 11 commits into from
Closed

Added some event-prefixes, ref #249 #423

wants to merge 11 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 9, 2018

@colinmollenhour
Copy link
Member

Note, while this is a good change it does have some potential to break stuff for people who were using the core_abstract prefix before.. It is easy to fix but may not be obvious. Also, the method clearInstance uses only the prefixed event so the chances may be slightly higher here since there is only core_abstract_clear and not model_clear.

Here is an idea.. Add a migration script which checks the config for any observers of the core_abstract prefixed events and if they exist then add an admin notification.

@sreichel
Copy link
Contributor Author

For model save/delete using core_abstract should still work , but I wasnt aware of clearInstance method.

Closed till migration script is ready.

@sreichel sreichel closed this Jan 11, 2018
@LeeSaferite
Copy link
Contributor

Please don't get discouraged on this task. I think this is a highly useful PR and we all want to get it merged once it's ready.

@sreichel
Copy link
Contributor Author

No worries, but @colinmollenhour is jut right. I'll reopen soon ;)

@sreichel sreichel added the hold label Jan 11, 2018
@sreichel sreichel mentioned this pull request Mar 5, 2019
Closed
@sreichel
Copy link
Contributor Author

sreichel commented Jun 21, 2020 •
edited
Loading

Time to re-open :)

@colinmollenhour ... some time to add this?

@sreichel sreichel reopened this Jun 21, 2020
@sreichel sreichel marked this pull request as draft June 21, 2020 00:51
@github-actions github-actions bot added Component: AdminNotification Relates to Mage_AdminNotification Component: Adminhtml Relates to Mage_Adminhtml Component: Admin Relates to Mage_Admin Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogRule Relates to Mage_CatalogRule Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer labels Jul 24, 2020
@sreichel sreichel mentioned this pull request Mar 4, 2021
Merged
3 tasks
@github-actions github-actions bot added Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: Index Relates to Mage_Index Component: Log Relates to Mage_Log Component: Oauth Relates to Mage_Oauth Component: Poll Relates to Mage_Poll Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Sitemap Relates to Mage_Sitemap Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Wishlist Relates to Mage_Wishlist labels Aug 11, 2022
@OpenMage OpenMage deleted a comment from addison74 Aug 11, 2022
@sreichel
Copy link
Contributor Author

Rebased.

Btw ... sorry for not doing so much reviews/tests.

I want to finish what i've started ... full IDE-support, make phpstan work ... no complaints from phpcs ...

@sreichel sreichel marked this pull request as ready for review August 11, 2022 01:37
@sreichel sreichel marked this pull request as draft September 3, 2022 06:35
@sreichel
Merge branch '1.9.4.x' into feature/event-prefixes
e616609 
# Conflicts:
#	app/code/core/Mage/Api2/Model/Acl/Filter/Attribute.php
#	app/code/core/Mage/Api2/Model/Acl/Global/Role.php
#	app/code/core/Mage/Api2/Model/Acl/Global/Rule.php
#	app/code/core/Mage/Bundle/Model/Option.php
#	app/code/core/Mage/Bundle/Model/Selection.php
#	app/code/core/Mage/Catalog/Model/Product/Option.php
#	app/code/core/Mage/Catalog/Model/Product/Type/Configurable/Attribute.php
#	app/code/core/Mage/Customer/Model/Resource/Address/Collection.php
#	app/code/core/Mage/Customer/Model/Resource/Customer/Collection.php
#	app/code/core/Mage/Downloadable/Model/Link.php
#	app/code/core/Mage/Eav/Model/Entity/Attribute/Group.php
#	app/code/core/Mage/Eav/Model/Entity/Store.php
#	app/code/core/Mage/Eav/Model/Entity/Type.php
#	app/code/core/Mage/Oauth/Model/Consumer.php
#	app/code/core/Mage/Reports/Model/Product/Index/Compared.php
#	app/code/core/Mage/Review/Model/Review/Summary.php
#	app/code/core/Mage/Sales/Model/Entity/Order/Address/Collection.php
#	app/code/core/Mage/Sales/Model/Entity/Order/Status/History/Collection.php
#	app/code/core/Mage/Sales/Model/Order/Creditmemo/Comment.php
#	app/code/core/Mage/Sales/Model/Order/Invoice/Comment.php
#	app/code/core/Mage/Sales/Model/Order/Shipment/Comment.php
#	app/code/core/Mage/Sales/Model/Quote/Item/Option.php
#	app/code/core/Mage/Tag/Model/Tag/Relation.php
#	app/code/core/Mage/Tax/Model/Calculation.php
#	app/code/core/Mage/Wishlist/Model/Item/Option.php
@sreichel
Merge branch '1.9.4.x' into feature/event-prefixes
763d720
@sreichel
Merge branch '1.9.4.x' into feature/event-prefixes
5e8c83c
@sreichel sreichel closed this by deleting the head repository Jan 8, 2023
@addison74 addison74 reopened this Jan 9, 2023
@sreichel sreichel closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@colinmollenhour colinmollenhour Awaiting requested review from colinmollenhour

Assignees
No one assigned
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogRule Relates to Mage_CatalogRule Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: Index Relates to Mage_Index Component: Log Relates to Mage_Log Component: Oauth Relates to Mage_Oauth Component: Poll Relates to Mage_Poll Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Sitemap Relates to Mage_Sitemap Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Wishlist Relates to Mage_Wishlist enhancement help wanted new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sreichel @colinmollenhour @LeeSaferite @kiatng @addison74 @fballiano