Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan: added some class vars to templates #4322

Merged
merged 1 commit into from
Oct 30, 2024
Merged

PHPStan: added some class vars to templates #4322

merged 1 commit into from
Oct 30, 2024

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 29, 2024 •
edited by addison74
Loading

Description (*)

IDE can now link blocks /w template files.

Added composer short-cut to generate phpostan basline

composer run phpstan:baseline

@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Template : admin Relates to admin template Component: Customer Relates to Mage_Customer Template : rwd Relates to rwd template Component: Adminhtml Relates to Mage_Adminhtml Component: Captcha Relates to Mage_Captcha Component: Widget Relates to Mage_Widget Component: Weee Relates to Mage_Weee composer Relates to composer.json phpstan labels Oct 29, 2024
@sreichel sreichel merged commit 7427284 into OpenMage:main Oct 30, 2024
19 checks passed
@sreichel sreichel deleted the phpstan-5 branch October 30, 2024 04:14
fballiano added a commit to MahoCommerce/maho that referenced this pull request Oct 30, 2024
@fballiano
OM PR 4322
a417d2b 
OpenMage/magento-lts#4322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: Customer Relates to Mage_Customer Component: Weee Relates to Mage_Weee Component: Widget Relates to Mage_Widget composer Relates to composer.json phpstan Template : admin Relates to admin template Template : rwd Relates to rwd template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @kiatng @addison74