Hierarchical accountant #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvadym
reviewed
Nov 28, 2021
dvadym
reviewed
Nov 28, 2021
| @@ -90,7 +90,6 @@ class SumParams: | |||
| max_contributions_per_partition: int | |||
| low: float | |||
| high: float | |||
| budget_weight: float | |||
There was a problem hiding this comment.
Please return back this as well
| @@ -52,6 +52,13 @@ def aggregate(self, col, params: AggregateParams, | |||
| """ | |||
| if params is None: | |||
| return None | |||
|
|
|||
| with self._budget_accountant.scope(weight=params.budget_weight): | |||
There was a problem hiding this comment.
I like an idea to create internal aggregate instead of having with on the entire function!
Tests are failing. Please return back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing budget accounting scopes.
The current budget accountant supports proportional budget allocation, where each DP operation can specify some relative “weight” and the budget accountant looks at all operations and distributes the global budget proportionally. This is nice.
However, if an operation contains multiple sub-operations, they all need to be aware of the weight of the parent operation, which needs manual piping of the weight, and multiplying weights of the sub-operations by the parent weight.
Manually ensuring that the sub-operations sum up to the parent weight is error-prone. This change suggests a convenient API that allows to scope DP operations and automatically ensure that the weight of each sub-operation is correctly normalised.
How has this been tested?
A unit test.
Checklist