Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple stage names generator #128

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Multiple stage names generator #128

merged 3 commits into from
Jan 11, 2022

Conversation

jspacek
Copy link
Member

@jspacek jspacek commented Dec 22, 2021 •
edited
Loading

Description

Adds a class to generate unique stage names in Beam so we can use the same names in multiple pipelines. See #124.

Affected Dependencies

How has this been tested?

  • Unit tests in pipeline_operations_tests for all beam operations.

Checklist

@jspacek jspacek force-pushed the beam-ops-unq-labels branch 2 times, most recently from 7507b08 to a7b6a54 Compare December 22, 2021 21:57
@jspacek jspacek requested a review from dvadym December 22, 2021 22:54
dvadym
dvadym reviewed Jan 2, 2022
View reviewed changes
Copy link
Collaborator

@dvadym dvadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks it looks good! I left some comments

pipeline_dp/pipeline_operations.py Outdated Show resolved Hide resolved
pipeline_dp/pipeline_operations.py Outdated Show resolved Hide resolved
pipeline_dp/pipeline_operations.py Outdated Show resolved Hide resolved
pipeline_dp/pipeline_operations.py Outdated Show resolved Hide resolved
pipeline_dp/pipeline_operations.py Outdated Show resolved Hide resolved
tests/pipeline_operations_test.py Outdated Show resolved Hide resolved
tests/pipeline_operations_test.py Outdated Show resolved Hide resolved
tests/pipeline_operations_test.py Outdated Show resolved Hide resolved
tests/pipeline_operations_test.py Show resolved Hide resolved
@jspacek jspacek force-pushed the beam-ops-unq-labels branch 2 times, most recently from c56388f to 990743c Compare January 11, 2022 02:13
@jspacek jspacek requested a review from dvadym January 11, 2022 16:02
dvadym
dvadym requested changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@dvadym dvadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

tests/pipeline_operations_test.py Show resolved Hide resolved
@dvadym dvadym merged commit abbcdbe into OpenMined:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvadym dvadym dvadym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jspacek @dvadym